Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1756: Add early_result_type to CompletedUserJourney #1592

Merged
merged 1 commit into from
Oct 10, 2024
Merged

EL-1756: Add early_result_type to CompletedUserJourney #1592

merged 1 commit into from
Oct 10, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

Jira ticket

What changed and why

  • add early_result_type to CompletedUserJourney

Guidance to review

  • n/a

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review October 10, 2024 14:35
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner October 10, 2024 14:35
@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive and removed Ready For Review labels Oct 10, 2024
@MazOneTwoOne MazOneTwoOne merged commit fbf4386 into main Oct 10, 2024
13 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1756-early-result-type branch October 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HettieS HettieS HettieS approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @HettieS