Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1787 update puppetteer to 23.5.3 #1600

Merged
merged 3 commits into from
Oct 21, 2024
Merged

EL-1787 update puppetteer to 23.5.3 #1600

merged 3 commits into from
Oct 21, 2024

Conversation

willc-work
Copy link
Contributor

Jira ticket

What changed and why

Update puppeteer manually

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@willc-work willc-work requested a review from a team as a code owner October 15, 2024 14:16
@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive and removed Ready For Review labels Oct 15, 2024
@willc-work willc-work changed the title update puppetteer to 23.5.3 EL-1787 update puppetteer to 23.5.3 Oct 15, 2024
@MazOneTwoOne MazOneTwoOne removed the UAT Keep PR open to keep ephemeral UAT URL alive label Oct 16, 2024
@willc-work willc-work added the UAT Keep PR open to keep ephemeral UAT URL alive label Oct 16, 2024
@HettieS HettieS merged commit b4ebfce into main Oct 21, 2024
13 checks passed
@HettieS HettieS deleted the puppeteer-2353 branch October 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazOneTwoOne MazOneTwoOne MazOneTwoOne approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willc-work @MazOneTwoOne @HettieS