Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1814: Manual upgrade of puppeteer to 23.6.0 #1614

Merged
merged 4 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ executors:
test-executor:
resource_class: medium
docker:
- image: checkclientqualifiesdocker/circleci-image:puppeteer-2353
- image: checkclientqualifiesdocker/circleci-image:puppeteer-2360
auth:
username: $DOCKERHUB_USER_CCQ
password: $DOCKERHUB_PAT_CCQ
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/browser_tools_docker_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
push:
branches:
- main
- puppeteer-2353
- puppeteer-2360

jobs:
build-push:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile_browser_tools.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN sudo apt install pdftk --allow-unauthenticated

# These 2 lines still need to mirror the actual version
# used by the application (in yarn.lock, not package.json)
RUN yarn add puppeteer@23.5.3
RUN yarn add puppeteer@23.6.0
RUN npx puppeteer browsers install chrome

COPY . .
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"esbuild": "^0.24.0",
"govuk-frontend": "^5.6.0",
"jquery": "^3.7.1",
"puppeteer": "23.5.3",
"puppeteer": "23.6.0",
"rails_admin": "3.2.0",
"sass": "^1.79.4"
},
Expand Down
30 changes: 15 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,10 @@ degenerator@^5.0.0:
escodegen "^2.1.0"
esprima "^4.0.1"

[email protected].1342118:
version "0.0.1342118"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1342118.tgz#ea136fc1701572c0830233dcb414dc857e582e0a"
integrity sha512-75fMas7PkYNDTmDyb6PRJCH7ILmHLp+BhrZGeMsa4bCh40DTxgCz2NRy5UDzII4C5KuD0oBMZ9vXKhEl6UD/3w==
[email protected].1354347:
version "0.0.1354347"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1354347.tgz#5cb509610b8f61fc69a31e5c810d5bed002d85ea"
integrity sha512-BlmkSqV0V84E2WnEnoPnwyix57rQxAM5SKJjf4TbYOCGLAWtz8CDH8RIaGOjPgPCXo2Mce3kxSY497OySidY3Q==

emoji-regex@^8.0.0:
version "8.0.0"
Expand Down Expand Up @@ -898,28 +898,28 @@ pump@^3.0.0:
end-of-stream "^1.1.0"
once "^1.3.1"

puppeteer-core@23.5.3:
version "23.5.3"
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-23.5.3.tgz#f53af458d59d08ec256d56d17689818592d9166a"
integrity sha512-V58MZD/B3CwkYsqSEQlHKbavMJptF04fzhMdUpiCRCmUVhwZNwSGEPhaiZ1f8I3ABQUirg3VNhXVB6Z1ubHXtQ==
puppeteer-core@23.6.0:
version "23.6.0"
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-23.6.0.tgz#a3e1e09c05f47fb8ca2bc9d4ca200d18e3704303"
integrity sha512-se1bhgUpR9C529SgHGr/eyT92mYyQPAhA2S9pGtGrVG2xob9qE6Pbp7TlqiSPlnnY1lINqhn6/67EwkdzOmKqQ==
dependencies:
"@puppeteer/browsers" "2.4.0"
chromium-bidi "0.8.0"
debug "^4.3.7"
devtools-protocol "0.0.1342118"
devtools-protocol "0.0.1354347"
typed-query-selector "^2.12.0"
ws "^8.18.0"

puppeteer@23.5.3:
version "23.5.3"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-23.5.3.tgz#aba7fbf39d8d9bb0c8d48a78e26ef169ed812685"
integrity sha512-FghmfBsr/UUpe48OiCg1gV3W4vVfQJKjQehbF07SjnQvEpWcvPTah1nykfGWdOQQ1ydJPIXcajzWN7fliCU3zw==
puppeteer@23.6.0:
version "23.6.0"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-23.6.0.tgz#7a3c01e7b6a43a950f3e13eb48a335f78a358768"
integrity sha512-l+Fgo8SVFSd51STtq2crz8t1Y3VXowsuR4zfR64qDOn6oggz7YIZauWiNR4IJjczQ6nvFs3S4cgng55/nesxTQ==
dependencies:
"@puppeteer/browsers" "2.4.0"
chromium-bidi "0.8.0"
cosmiconfig "^9.0.0"
devtools-protocol "0.0.1342118"
puppeteer-core "23.5.3"
devtools-protocol "0.0.1354347"
puppeteer-core "23.6.0"
typed-query-selector "^2.12.0"

queue-tick@^1.0.1:
Expand Down