Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1048: Refactor check answer screen to use cards #843

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

patrick-laa
Copy link
Contributor

Jira ticket

What changed and why

The check answers screen now uses cards
The yaml file now defines how 'add another' works, both for adding another card and adding another field within a card
The yaml file also fully defines when to show the disputed asset tag
Check answers 'Change' links to add another screens now have anchors to the appropriate section on the page
The system for anchors back to the check answers screen is now much simpler and doesn't need a separate service to define anchor IDs.

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@patrick-laa patrick-laa marked this pull request as ready for review July 24, 2023 12:05
@patrick-laa patrick-laa requested a review from a team as a code owner July 24, 2023 12:05
Copy link
Contributor

@willc-work willc-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I especially like the expect_in_text method 👍

@patrick-laa patrick-laa added the UAT Keep PR open to keep ephemeral UAT URL alive label Jul 25, 2023
@patrick-laa patrick-laa merged commit 3956269 into main Jul 27, 2023
4 checks passed
@patrick-laa patrick-laa deleted the EL-1048-check-answers-cards branch July 27, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants