Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCAM-1401 #123

Merged
merged 8 commits into from
Oct 2, 2024
Merged

LCAM-1401 #123

merged 8 commits into from
Oct 2, 2024

Conversation

Mhowell494
Copy link
Contributor

Link to story

  • Migrate validation scattered throughout the manage_income_evidence stored procedure into a centralised location within the evidence service.
  • Unit test cases for the new validation checks.

@muthusubra @Mhowell494
Changes to Migrate Validation Checks In MANAGE_INCOME_EVIDENCE Stored…
3e27386 
… Procedure to the Evidence Service

(cherry picked from commit 3c16034)
@Mhowell494 Mhowell494 requested a review from a team as a code owner September 13, 2024 16:18
Mhowell494
Mhowell494 commented Sep 24, 2024
View reviewed changes
Copy link
Contributor Author

@Mhowell494 Mhowell494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor points.

Can we also please add a method in the Controller class e.g. preProcessRequest() that invokes these checks? I also think we could increase the code coverage a little.

...nce/src/main/java/uk/gov/justice/laa/crime/evidence/staticdata/enums/OtherEvidenceTypes.java Outdated Show resolved Hide resolved
...src/main/java/uk/gov/justice/laa/crime/evidence/service/IncomeEvidenceValidationService.java Outdated Show resolved Hide resolved
@muthusubra
Copy link
Contributor

preProcessRequest

As discussed offline, added a validate method in service class and added DTO with just the required fields

@karlbaker02 karlbaker02 mentioned this pull request Sep 26, 2024
Closed
@Mhowell494 Mhowell494 closed this Oct 1, 2024
@Mhowell494 Mhowell494 reopened this Oct 1, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Mhowell494
Mhowell494 commented Oct 2, 2024
View reviewed changes
Copy link
Contributor Author

@Mhowell494 Mhowell494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M - can't approve as I created the PR

karlbaker02
karlbaker02 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@karlbaker02 karlbaker02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @Mhowell494

@Mhowell494 Mhowell494 merged commit f6e4f60 into main Oct 2, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthusubra muthusubra muthusubra left review comments

@venkat980 venkat980 venkat980 left review comments

@karlbaker02 karlbaker02 karlbaker02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mhowell494 @muthusubra @karlbaker02 @venkat980