Migrate manage income evidence stored procedure #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlbaker02
changed the title
karlbaker02
force-pushed
the
karlb/lcam-1404-migrate-manage-income-evidence
branch
11 times, most recently
from
a125d28 to
3d08441
Compare
…ervice This commit implements and refactors the logic from _manage_income_evidence_ stored procedure from the legacy database into the Evidence Service. Some of the logic in the stored procedure has not been implemented as it is no longer applicable or necessary, or is defined as part of a separate story, such as migrating the create_default_income_evidence stored procedure.
karlbaker02
force-pushed
the
karlb/lcam-1404-migrate-manage-income-evidence
branch
2 times, most recently
from
cd6e9e4 to
f8def0f
Compare
This commit makes changes in line with a new decision to update the income evidence not within the Evidence Service as initially thought but instead to do this within the Orchestration Service. As such, the CMA client and calls to it are removed, with new fields instead introduced via an update of the mod schemas to version `1.16.0` to replace the information previously obtained from the CMA Service.
karlbaker02
force-pushed
the
karlb/lcam-1404-migrate-manage-income-evidence
branch
from
af801f8 to
72cb0da
Compare
|
karlbaker02
deleted the
karlb/lcam-1404-migrate-manage-income-evidence
branch
lkm0287
reviewed
Oct 28, 2024
| and ((i2.partner_emst_code is null and ?3 is null) or (i2.partner_emst_code = ?3)) | ||
| and I2.APPLICANT_PARTNER = ?4 | ||
| and i2.ANNUAL_PENSION_AMOUNT <= nvl(?5,0) | ||
| and i2.ANNUAL_PENSION_AMOUNT > I.ANNUAL_PENSION_AMOUNT) |
There was a problem hiding this comment.
This would be a good candidate for adding some indexes to the DB for - imagine it's slow to run!
There was a problem hiding this comment.
Could be, I didn't check if it has any indexes already but this is the same query that's currently in one of the nested stored procedures, so should at least be no worse than it currently is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the income evidence stored procedure to the Evidence Service, refactoring the existing logic at the same time as migrating and operating on the following directions and assumptions:
check_valuesfrom the stored procedure as this has already been front-loaded into the serviceAs part of migrating the logic from the stored procedure, it is now necessary to call out to the CMA service to find the means assessment that is requested to be updated, before then calling back later with the rest to update that assessment with the evidence passed in.
This PR also updates crime-commons mod schemas from version
1.8.0to1.16.0.Link to story