Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LASB-3637 - implement sentry DSN value as secret #146

Merged
merged 1 commit into from
Jan 23, 2025
Merged

LASB-3637 - implement sentry DSN value as secret #146

merged 1 commit into from
Jan 23, 2025

Conversation

lkm0287
Copy link
Contributor

@lkm0287 lkm0287 commented Jan 22, 2025

What

Link to story

Checklist

Before you ask people to review this PR:

  • Tests should be passing: ./gradlew test
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Additional checks

  • Don’t forget to run the MAAT functional test suite after deploying your changes to the DEV or TEST environments to ensure your changes haven’t broken any of the functional tests.

@lkm0287 lkm0287 requested a review from a team as a code owner January 22, 2025 16:47
Copy link

@Ross-Nation Ross-Nation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos!

@lkm0287 lkm0287 merged commit 843431b into main Jan 23, 2025
8 of 9 checks passed
@lkm0287 lkm0287 deleted the LASB-3637 branch January 23, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants