Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCAM-985: Upgraded crime commons version and enabled micrometer tracing #64

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

skasthuri36326
Copy link
Contributor

@skasthuri36326 skasthuri36326 commented Oct 18, 2023

What

LCAM-985

Describe what you did and why.

  • Upgraded to crime commons v2.7.0 to include micrometer tracing
  • Updated Exception handler to include traceId in error response
  • Updated application.yaml to enable micrometer tracing for Evidence
  • Updated logback.xml to include traceId and spanId
  • Updated controller and Integration tests

Checklist

Before you ask people to review this PR:

  • Tests should be passing: ./gradlew test
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@skasthuri36326 skasthuri36326 requested a review from a team as a code owner October 18, 2023 14:26
@skasthuri36326 skasthuri36326 merged commit d4952e9 into main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants