Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:dependabot: Bumping various dependencies #118

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

ASTRobinson
Copy link
Contributor

@ASTRobinson ASTRobinson commented Oct 3, 2024

This PR bumps the Go version to 1.23, python to 3.12, the S3 bucket module to v8.2.0, and unit-test TSA errors.

@ASTRobinson ASTRobinson requested a review from a team as a code owner October 3, 2024 14:56
@ASTRobinson ASTRobinson closed this Oct 3, 2024
@ASTRobinson ASTRobinson reopened this Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ASTRobinson ASTRobinson force-pushed the dependabot/update-dependencies branch from 28aab94 to 49a5370 Compare October 3, 2024 16:07
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
@ministryofjustice ministryofjustice deleted a comment from github-actions bot Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
test/unit-test


Running Trivy in test/unit-test
2024-10-03T16:09:40Z INFO [vulndb] Need to update DB
2024-10-03T16:09:40Z INFO [vulndb] Downloading vulnerability DB...
2024-10-03T16:09:40Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-03T16:09:42Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-03T16:09:42Z INFO [vuln] Vulnerability scanning is enabled
2024-10-03T16:09:42Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-03T16:09:42Z INFO [misconfig] Need to update the built-in checks
2024-10-03T16:09:42Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-10-03T16:09:42Z INFO [secret] Secret scanning is enabled
2024-10-03T16:09:42Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-03T16:09:42Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-03T16:09:43Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-03T16:09:43Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-03T16:09:43Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-03T16:09:44Z INFO [terraform executor] Ignore finding rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=52a40b0dd18aaef0d7c5565d93cc8997aad79636/main.tf:187-197"
2024-10-03T16:09:44Z INFO Number of language-specific files num=0
2024-10-03T16:09:44Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
test/unit-test

*****************************

Running Checkov in test/unit-test
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-10-03 16:09:46,407 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=52a40b0dd18aaef0d7c5565d93cc8997aad79636:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 76, Failed checks: 0, Skipped checks: 14


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
test/unit-test

*****************************

Running tflint in test/unit-test
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
test/unit-test

*****************************

Running Trivy in test/unit-test
2024-10-03T16:09:40Z	INFO	[vulndb] Need to update DB
2024-10-03T16:09:40Z	INFO	[vulndb] Downloading vulnerability DB...
2024-10-03T16:09:40Z	INFO	[vulndb] Downloading artifact...	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-03T16:09:42Z	INFO	[vulndb] Artifact successfully downloaded	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-03T16:09:42Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-03T16:09:42Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-03T16:09:42Z	INFO	[misconfig] Need to update the built-in checks
2024-10-03T16:09:42Z	INFO	[misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-10-03T16:09:42Z	INFO	[secret] Secret scanning is enabled
2024-10-03T16:09:42Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-03T16:09:42Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-03T16:09:43Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-03T16:09:43Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.expiration" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.transition" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.noncurrent_version_expiration" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.noncurrent_version_transition" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.principals" value="cty.NilVal"
2024-10-03T16:09:43Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.s3-bucket.dynamic.condition" value="cty.NilVal"
2024-10-03T16:09:44Z	INFO	[terraform executor] Ignore finding	rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=52a40b0dd18aaef0d7c5565d93cc8997aad79636/main.tf:187-197"
2024-10-03T16:09:44Z	INFO	Number of language-specific files	num=0
2024-10-03T16:09:44Z	INFO	Detected config files	num=3
trivy_exitcode=0

@ASTRobinson ASTRobinson changed the title :dependabot: bump go version to 1.23 :dependabot: Bumping various dependencies Oct 3, 2024
@@ -144,7 +144,7 @@ data "aws_iam_policy_document" "instance-scheduler-lambda-function-policy" {
]
resources = [
"${module.s3-bucket.bucket.arn}/*",
"${module.s3-bucket.bucket.arn}"
module.s3-bucket.bucket.arn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ASTRobinson ASTRobinson merged commit e00a1f2 into main Oct 3, 2024
9 checks passed
@ASTRobinson ASTRobinson deleted the dependabot/update-dependencies branch October 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants