Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nart team access to test, preproduction and production onr envs #6616

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

robertsweetman
Copy link
Contributor

A reference to the issue / Description of it

Nart team need access to oasys-national-reporting environment, mainly to familiarise themselves as it's moved

How does this PR fix the problem?

Gives them access

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

Adding github stub, should just work

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@robertsweetman robertsweetman requested a review from a team as a code owner March 26, 2024 17:07
@github-actions github-actions bot added the onboarding Tasks to onboard teams label Mar 26, 2024
Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments/*.json files will affect MP AWS accounts, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@robertsweetman robertsweetman merged commit d8ac71f into main Mar 26, 2024
14 checks passed
@robertsweetman robertsweetman deleted the DSOS-2689/give-nart-team-access-to-onr-env branch March 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants