Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add networking files for delete-account #6663

Merged

Conversation

richgreen-moj
Copy link
Contributor

A reference to the issue / Description of it

#6457

How does this PR fix the problem?

Creating networks for delete-account

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj requested a review from a team as a code owner April 2, 2024 12:40
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Please check the plan carefully before deploying these changes.

⚠️ Making changes to the environments-networks/*.json files will affect the networking of MP AWS accounts, in particular which VPC/Subnet is being shared in to which environment. For more guidance consult the documentation.

@github-actions github-actions bot added onboarding Tasks to onboard teams testing labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@richgreen-moj richgreen-moj merged commit 81f6d47 into main Apr 2, 2024
11 checks passed
@richgreen-moj richgreen-moj deleted the feature/6457-create-networking-for-delete-account branch April 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Tasks to onboard teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants