DST-16098 Send Domain Event when username is changed #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcus-bcl
requested changes
Aug 20, 2024
src/main/java/uk/co/bconline/ndelius/model/notification/SnsMessageRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/DomainEventServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/co/bconline/ndelius/service/impl/UserEntryServiceImpl.java
Outdated
Show resolved
Hide resolved
marcus-bcl
changed the title
marcus-bcl
reviewed
Aug 20, 2024
| import static java.util.Optional.ofNullable; | ||
|
|
||
| @Component | ||
| public class DomainEventTransformer |
There was a problem hiding this comment.
Can we delete this class now?
Comment on lines
263
to
264
| public void save(String existingUsername, UserEntry user) throws JsonProcessingException | ||
| { |
There was a problem hiding this comment.
Sorry - could we annotate insertDomainEvent with @SneakyThrows so that we don't have to declare this exception all the way up?
Suggested change
| public void save(String existingUsername, UserEntry user) throws JsonProcessingException | |
| { | |
| public void save(String existingUsername, UserEntry user) | |
| { |
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Builder | ||
| public class DomainEvent |
There was a problem hiding this comment.
Can we delete this now too?
marcus-bcl
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send Domain Event when username is changed