Merge pull request #791 from ministryofjustice/ND-543-update-tools

added signed commits links and few corrections
ministryofjustice · Nov 7, 2024 · d790e03 · d790e03
2 parents 6d6fa7f + 9d8f018
commit d790e03
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/source/documentation/team-guide/team-onboarding-checklist.html.md.erb b/source/documentation/team-guide/team-onboarding-checklist.html.md.erb
@@ -67,16 +67,16 @@ Request access to the following :
 
 - NACs Admin - Get access to the Dev, Pre-prod and Prod portals by asking to be added as an admin user by emailing the LAN/WiFi team on [email protected] - include your email addressin and full name the request.
 
-    - Dev - https://admin.dev.network-access-control.service.justice.gov.uk/sign_in
+    - Dev - <https://admin.dev.network-access-control.service.justice.gov.uk/sign_in>
 
-    - Pre-production - https://admin.prep.network-access-control.service.justice.gov.uk/sign_in
+    - Pre-production - <https://admin.prep.network-access-control.service.justice.gov.uk/sign_in>
 
-    - Production - https://admin.network-access-control.service.justice.gov.uk/sign_in
+    - Production - <https://admin.network-access-control.service.justice.gov.uk/sign_in>
 
 - DNS DHCP Admin - Get access to the Dev, Pre-prod and Prod portals by asking to be added as an admin user on the lan_wifi-team-channel in Slack - include your email addressin the request.
 
-    - Dev - https://dhcp-dns-admin.dev.staff.service.justice.gov.uk/sign_in
+    - Dev - <https://dhcp-dns-admin.dev.staff.service.justice.gov.uk/sign_in>
 
-    - Pre-production - https://dhcp-dns-admin.prep.staff.service.justice.gov.uk/sign_in
+    - Pre-production - <https://dhcp-dns-admin.prep.staff.service.justice.gov.uk/sign_in>
 
-    - Production - https://dhcp-dns-admin.staff.service.justice.gov.uk/sign_in
+    - Production - <https://dhcp-dns-admin.staff.service.justice.gov.uk/sign_in>
diff --git a/source/documentation/team-guide/team-tools.html.md.erb b/source/documentation/team-guide/team-tools.html.md.erb
@@ -66,3 +66,6 @@ Some of our preferred extensions are listed below, to install these extensions o
 
 If you've installed any Extensions prior to installing Remote WSL, re-install them on the WSL Ubuntu. To do this an 'Install' button should appear on these extensions when viewed on the Extensions (under WSL:
 Ubuntu) submenu on the left hand side of VS Code.
+
+### Signing GitHub Commits
+Some of our repos are configured to accept only signed commits. Please follow these [instructions](https://ministryofjustice.github.io/nvvs-devops/documentation/team-guide/best-practices/signing-github-commits.html#configure-git-with-the-gpg-key) to generate and use GPG as your signing key.