Add channel field to LPA

To be used in future validation: if the LPA comes through the paper channel then validation wll be more lenient Originally part of MLPAB-1535 #minor
ministryofjustice · May 8, 2024 · 3550633 · 3550633
1 parent 36e7f55
commit 3550633
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 2 deletions.
diff --git a/docs/example-lpa.json b/docs/example-lpa.json
@@ -1,5 +1,6 @@
 {
   "lpaType": "personal-welfare",
+  "channel": "online",
   "donor": {
     "uid": "eda719db-8880-4dda-8c5d-bb9ea12c236f",
     "firstNames": "Feeg",

diff --git a/docs/schemas/2024-10/donor-details.json b/docs/schemas/2024-10/donor-details.json
@@ -5,6 +5,7 @@
   "type": "object",
   "required": [
     "lpaType",
+    "channel",
     "donor",
     "attorneys",
     "certificateProvider",
@@ -15,6 +16,10 @@
       "type": "string",
       "enum": ["property-and-affairs", "personal-welfare"]
     },
+    "channel": {
+      "type": "string",
+      "enum": ["paper", "online"]
+    },
     "donor": {
       "allOf": [
         {

diff --git a/fixtures/templates/index.html b/fixtures/templates/index.html
@@ -87,7 +87,7 @@ <h2 class="govuk-error-summary__title">{{ error.detail }}</h2>
               required
               rows="10"
               data-module="json-schema-editor"
-              data-module-json-schema-editor-url="assets/schemas/2024-10/lpa.json"
+              data-module-json-schema-editor-url="assets/schemas/2024-10/donor-details.json"
             >
               {{- json_data -}}
             </textarea>

diff --git a/internal/shared/lpa.go b/internal/shared/lpa.go
@@ -6,6 +6,7 @@ import (
 
 type LpaInit struct {
 	LpaType                                     LpaType                 `json:"lpaType"`
+	Channel                                     Channel                 `json:"channel"`
 	Donor                                       Donor                   `json:"donor"`
 	Attorneys                                   []Attorney              `json:"attorneys"`
 	TrustCorporations                           []TrustCorporation      `json:"trustCorporations,omitempty"`

diff --git a/internal/shared/lpa_test.go b/internal/shared/lpa_test.go
@@ -9,7 +9,7 @@ import (
 
 func TestLpaInitMarshalJSON(t *testing.T) {
 	expected := `{
-"lpaType":"",
+"lpaType":"","channel":"",
 "donor":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","country":""},"dateOfBirth":"","email":"","contactLanguagePreference":""},
 "attorneys":null,
 "certificateProvider":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","country":""},"email":"","phone":"","channel":""},

diff --git a/lambda/create/validate.go b/lambda/create/validate.go
@@ -12,6 +12,7 @@ func Validate(lpa shared.LpaInit) []shared.FieldError {
 
 	return validate.All(
 		validate.IsValid("/lpaType", lpa.LpaType),
+		validate.IsValid("/channel", lpa.Channel),
 		validate.UUID("/donor/uid", lpa.Donor.UID),
 		validate.Required("/donor/firstNames", lpa.Donor.FirstNames),
 		validate.Required("/donor/lastName", lpa.Donor.LastName),

diff --git a/lambda/create/validate_test.go b/lambda/create/validate_test.go
@@ -78,6 +78,7 @@ func makeTrustCorporation() shared.TrustCorporation {
 func makeLpaWithDonorAndActors() shared.LpaInit {
 	return shared.LpaInit{
 		LpaType: shared.LpaTypePropertyAndAffairs,
+		Channel: shared.ChannelOnline,
 		Donor: shared.Donor{
 			Person: shared.Person{
 				UID:        "b99af83d-5b6c-44f7-8c03-14004699bdb9",
@@ -192,6 +193,7 @@ func TestValidateLpaInvalid(t *testing.T) {
 			lpa: func() shared.LpaInit { return shared.LpaInit{} },
 			expectedErrors: []shared.FieldError{
 				{Source: "/lpaType", Detail: "field is required"},
+				{Source: "/channel", Detail: "field is required"},
 				{Source: "/donor/uid", Detail: "field is required"},
 				{Source: "/donor/firstNames", Detail: "field is required"},
 				{Source: "/donor/lastName", Detail: "field is required"},

diff --git a/mock-apigw/main.go b/mock-apigw/main.go
@@ -127,6 +127,7 @@ func handlePactState(r *http.Request) error {
 		url := fmt.Sprintf("http://localhost:8080/lpas/%s", oldUID)
 		body := `{
 			"lpaType": "personal-welfare",
+			"channel": "online",
 			"donor": {
 				"uid": "34cd75eb-17bc-434a-b922-4772ce3e0439",
 				"firstNames": "Homer",