make appointmentType optional

ministryofjustice · Nov 15, 2024 · 3ada094 · 3ada094
1 parent d8051bb
commit 3ada094
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/internal/shared/person.go b/internal/shared/person.go
@@ -74,7 +74,7 @@ const (
 )
 
 func (a AppointmentType) IsValid() bool {
-	return a == AppointmentTypeOriginal || a == AppointmentTypeReplacement
+	return true
 }
 
 type Attorney struct {

diff --git a/lambda/create/validate.go b/lambda/create/validate.go
@@ -125,7 +125,6 @@ func validateAttorney(prefix string, attorney shared.Attorney) []shared.FieldErr
 		validate.Date(fmt.Sprintf("%s/dateOfBirth", prefix), attorney.DateOfBirth),
 		validate.Address(fmt.Sprintf("%s/address", prefix), attorney.Address),
 		validate.IsValid(fmt.Sprintf("%s/status", prefix), attorney.Status),
-		validate.IsValid(fmt.Sprintf("%s/appointmentType", prefix), attorney.AppointmentType),
 		validate.IsValid(fmt.Sprintf("%s/channel", prefix), attorney.Channel),
 		validate.IfElse(attorney.Channel == shared.ChannelOnline,
 			validate.Required(fmt.Sprintf("%s/email", prefix), attorney.Email),

diff --git a/lambda/create/validate_test.go b/lambda/create/validate_test.go
@@ -124,7 +124,6 @@ func TestValidateAttorneyEmpty(t *testing.T) {
 		{Source: "/test/firstNames", Detail: "field is required"},
 		{Source: "/test/lastName", Detail: "field is required"},
 		{Source: "/test/status", Detail: "field is required"},
-		{Source: "/test/appointmentType", Detail: "field is required"},
 		{Source: "/test/address/line1", Detail: "field is required"},
 		{Source: "/test/address/country", Detail: "field is required"},
 		{Source: "/test/address/country", Detail: "must be a valid ISO-3166-1 country code"},