Skip to content

Commit

Permalink
VEGA-2656 add appointment type to trust corporations (#279)
Browse files Browse the repository at this point in the history
* VEGA-2656 add appointment type to trust corporations
  • Loading branch information
MishNajam authored Nov 20, 2024
1 parent ca27962 commit 49ac85b
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 17 deletions.
1 change: 1 addition & 0 deletions docs/example-lpa.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"country": "GB"
},
"status": "active",
"appointmentType": "original",
"channel": "paper"
}
],
Expand Down
4 changes: 4 additions & 0 deletions docs/schemas/2024-10/lpa.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@
"items": {
"type": "object",
"properties": {
"appointmentType": {
"type": "string",
"enum": ["original", "replacement"]
},
"signedAt": {
"type": "string",
"format": "date-time"
Expand Down
21 changes: 11 additions & 10 deletions internal/shared/person.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,17 @@ type Attorney struct {
}

type TrustCorporation struct {
UID string `json:"uid"`
Name string `json:"name"`
CompanyNumber string `json:"companyNumber"`
Email string `json:"email,omitempty"`
Address Address `json:"address"`
Status AttorneyStatus `json:"status"`
Mobile string `json:"mobile,omitempty"`
Signatories []Signatory `json:"signatories,omitempty"`
ContactLanguagePreference Lang `json:"contactLanguagePreference,omitempty"`
Channel Channel `json:"channel"`
UID string `json:"uid"`
Name string `json:"name"`
CompanyNumber string `json:"companyNumber"`
Email string `json:"email,omitempty"`
AppointmentType AppointmentType `json:"appointmentType"`
Address Address `json:"address"`
Status AttorneyStatus `json:"status"`
Mobile string `json:"mobile,omitempty"`
Signatories []Signatory `json:"signatories,omitempty"`
ContactLanguagePreference Lang `json:"contactLanguagePreference,omitempty"`
Channel Channel `json:"channel"`
}

type Signatory struct {
Expand Down
15 changes: 8 additions & 7 deletions lambda/create/validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,14 @@ func makeCertificateProvider() shared.CertificateProvider {

func makeTrustCorporation() shared.TrustCorporation {
return shared.TrustCorporation{
UID: "af2f7aa6-2f8e-4311-af2a-4855c4686d30",
Name: "corp",
CompanyNumber: "5",
Email: "[email protected]",
Address: validAddress,
Status: shared.AttorneyStatusActive,
Channel: shared.ChannelOnline,
UID: "af2f7aa6-2f8e-4311-af2a-4855c4686d30",
Name: "corp",
CompanyNumber: "5",
Email: "[email protected]",
Address: validAddress,
AppointmentType: shared.AppointmentTypeOriginal,
Status: shared.AttorneyStatusActive,
Channel: shared.ChannelOnline,
}
}

Expand Down
1 change: 1 addition & 0 deletions mock-apigw/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ func handlePactState(r *http.Request) error {
"country": "GB"
},
"status": "active",
"appointmentType": "original",
"channel": "paper"
}
],
Expand Down

0 comments on commit 49ac85b

Please sign in to comment.