Skip to content

Commit

Permalink
Remove more tests that assert town as required
Browse files Browse the repository at this point in the history
  • Loading branch information
mabely committed Apr 29, 2024
1 parent a97f932 commit 4dcdf86
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions internal/shared/lpa_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import (
func TestLpaInitMarshalJSON(t *testing.T) {
expected := `{
"lpaType":"",
"donor":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","town":"","country":""},"dateOfBirth":"","email":"","contactLanguagePreference":""},
"donor":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","country":""},"dateOfBirth":"","email":"","contactLanguagePreference":""},
"attorneys":null,
"certificateProvider":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","town":"","country":""},"email":"","phone":"","channel":""},
"certificateProvider":{"uid":"","firstNames":"","lastName":"","address":{"line1":"","country":""},"email":"","phone":"","channel":""},
"signedAt":"0001-01-01T00:00:00Z"
}`

Expand Down
3 changes: 0 additions & 3 deletions lambda/create/validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (

var validAddress = shared.Address{
Line1: "123 Main St",
Town: "Homeland",
Country: "GB",
}

Expand Down Expand Up @@ -46,7 +45,6 @@ func TestValidateAttorneyEmpty(t *testing.T) {
assert.Contains(t, errors, shared.FieldError{Source: "/test/status", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/dateOfBirth", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/line1", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/town", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/country", Detail: "field is required"})
}

Expand Down Expand Up @@ -105,7 +103,6 @@ func TestValidateTrustCorporationEmpty(t *testing.T) {
assert.Contains(t, errors, shared.FieldError{Source: "/test/email", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/status", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/line1", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/town", Detail: "field is required"})
assert.Contains(t, errors, shared.FieldError{Source: "/test/address/country", Detail: "field is required"})
}

Expand Down

0 comments on commit 4dcdf86

Please sign in to comment.