Return 404 error when LPA is not retrieved VEGA-2203 #minor

ministryofjustice · Dec 15, 2023 · 8fbe7e8 · 8fbe7e8
1 parent 9e842e7
commit 8fbe7e8
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 1 deletion.
diff --git a/docs/openapi/openapi.yaml b/docs/openapi/openapi.yaml
@@ -68,6 +68,12 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/BadRequestError"
+        "404":
+          description: Case not found.
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/NotFoundError"
       x-amazon-apigateway-auth:
         type: "AWS_IAM"
       x-amazon-apigateway-integration:
@@ -189,6 +195,29 @@ components:
               example:
                 - source: "/uid"
                   detail: "invalid uid format"
+    NotFoundError:
+      allOf:
+        - $ref: "#/components/schemas/AbstractError"
+        - type: object
+          properties:
+            code:
+              enum: ["NOT_FOUND"]
+            errors:
+              type: array
+              items:
+                type: object
+                required:
+                  - source
+                  - detail
+                properties:
+                  source:
+                    type: string
+                    format: jsonpointer
+                  detail:
+                    type: string
+              example:
+                - source: "/uid"
+                  detail: "uid not found"
     Lpa:
       allOf:
         - $ref: "#/components/schemas/InitialLpa"

diff --git a/internal/shared/problem.go b/internal/shared/problem.go
@@ -48,6 +48,12 @@ var ProblemUnauthorisedRequest Problem = Problem{
 	Detail:     "Invalid JWT",
 }
 
+var ProblemNotFoundRequest Problem = Problem{
+	StatusCode: 404,
+	Code:       "NOT_FOUND",
+	Detail:     "Record not found",
+}
+
 func (problem Problem) Respond() (events.APIGatewayProxyResponse, error) {
 	var errorString = ""
 	for _, ve := range problem.Errors {

diff --git a/lambda/get/main.go b/lambda/get/main.go
@@ -38,7 +38,7 @@ func (l *Lambda) HandleEvent(ctx context.Context, event events.APIGatewayProxyRe
 
 	if err != nil {
 		l.logger.Print(err)
-		return shared.ProblemInternalServerError.Respond()
+		return shared.ProblemNotFoundRequest.Respond()
 	}
 
 	body, err := json.Marshal(lpa)