Make attorney channel optional (#187)

ministryofjustice · May 1, 2024 · a8649b3 · a8649b3
1 parent 5f0abea
commit a8649b3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/lambda/update/attorney_sign.go b/lambda/update/attorney_sign.go
@@ -62,7 +62,7 @@ func validateAttorneySign(changes []shared.Change, lpa *shared.Lpa) (AttorneySig
 						}), parse.MustMatchExisting()).
 						Field("/channel", &data.Channel, parse.Validate(func() []shared.FieldError {
 							return validate.IsValid("", data.Channel)
-						}), parse.MustMatchExisting()).
+						}), parse.MustMatchExisting(), parse.Optional()).
 						Field("/email", &data.Email, parse.MustMatchExisting(), parse.Optional()).
 						Consumed()
 				}).

diff --git a/lambda/update/attorney_sign_test.go b/lambda/update/attorney_sign_test.go
@@ -72,11 +72,6 @@ func TestValidateUpdateAttorneySign(t *testing.T) {
 						New: json.RawMessage(`"cy"`),
 						Old: jsonNull,
 					},
-					{
-						Key: "/attorneys/0/channel",
-						New: json.RawMessage(`"online"`),
-						Old: jsonNull,
-					},
 				},
 			},
 			lpa: &shared.Lpa{LpaInit: shared.LpaInit{Attorneys: []shared.Attorney{