relax email+channel validation until consumer tests updated

ministryofjustice · May 1, 2024 · f186be8 · f186be8
1 parent e2aade5
commit f186be8
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 28 deletions.
diff --git a/lambda/create/validate.go b/lambda/create/validate.go
@@ -127,8 +127,8 @@ func validateTrustCorporation(prefix string, trustCorporation shared.TrustCorpor
 		validate.Address(fmt.Sprintf("%s/address", prefix), trustCorporation.Address),
 		validate.IsValid(fmt.Sprintf("%s/channel", prefix), trustCorporation.Channel),
 		validate.IsValid(fmt.Sprintf("%s/status", prefix), trustCorporation.Status),
-		validate.IfElse(trustCorporation.Channel == shared.ChannelOnline,
-			validate.Required(fmt.Sprintf("%s/email", prefix), trustCorporation.Email),
-			validate.Empty(fmt.Sprintf("%s/email", prefix), trustCorporation.Email)),
+		//validate.IfElse(trustCorporation.Channel == shared.ChannelOnline,
+		//	validate.Required(fmt.Sprintf("%s/email", prefix), trustCorporation.Email),
+		//	validate.Empty(fmt.Sprintf("%s/email", prefix), trustCorporation.Email)),
 	)
 }
diff --git a/lambda/create/validate_test.go b/lambda/create/validate_test.go
@@ -299,31 +299,31 @@ func TestValidateLpaInvalid(t *testing.T) {
 				{Source: "/lifeSustainingTreatmentOption", Detail: "field must not be provided"},
 			},
 		},
-		"online trust corporation missing email": {
-			lpa: shared.LpaInit{
-				TrustCorporations: []shared.TrustCorporation{
-					{
-						Channel: shared.ChannelOnline,
-					},
-				},
-			},
-			contains: []shared.FieldError{
-				{Source: "/trustCorporations/0/email", Detail: "field is required"},
-			},
-		},
-		"paper trust corporation with email": {
-			lpa: shared.LpaInit{
-				TrustCorporations: []shared.TrustCorporation{
-					{
-						Channel: shared.ChannelPaper,
-						Email:   "[email protected]",
-					},
-				},
-			},
-			contains: []shared.FieldError{
-				{Source: "/trustCorporations/0/email", Detail: "field must not be provided"},
-			},
-		},
+		//"online trust corporation missing email": {
+		//	lpa: shared.LpaInit{
+		//		TrustCorporations: []shared.TrustCorporation{
+		//			{
+		//				Channel: shared.ChannelOnline,
+		//			},
+		//		},
+		//	},
+		//	contains: []shared.FieldError{
+		//		{Source: "/trustCorporations/0/email", Detail: "field is required"},
+		//	},
+		//},
+		//"paper trust corporation with email": {
+		//	lpa: shared.LpaInit{
+		//		TrustCorporations: []shared.TrustCorporation{
+		//			{
+		//				Channel: shared.ChannelPaper,
+		//				Email:   "[email protected]",
+		//			},
+		//		},
+		//	},
+		//	contains: []shared.FieldError{
+		//		{Source: "/trustCorporations/0/email", Detail: "field must not be provided"},
+		//	},
+		//},
 	}
 
 	for name, tc := range testcases {