Use slog for structured, standardised logs #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just switching out methods, but also use more appropriate log levels in a few places For CTC-138 #patch
mabely
reviewed
Mar 7, 2024
| @@ -50,11 +53,11 @@ type Lambda struct { | |||
| func (l *Lambda) HandleEvent(ctx context.Context, req events.APIGatewayProxyRequest) (events.APIGatewayProxyResponse, error) { | |||
| _, err := l.verifier.VerifyHeader(req) | |||
| if err != nil { | |||
| l.logger.Print("Unable to verify JWT from header") | |||
| l.logger.Info("Unable to verify JWT from header") | |||
There was a problem hiding this comment.
How come we would log this at info level rather than error?
There was a problem hiding this comment.
Error-level logs are for things which shouldn't go wrong, since they trigger alarms. This is just informational, since LPA store doesn't particularly care about a unauthorised request.
mabely
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just switching out methods, but also use more appropriate log levels in a few places
For CTC-138 #patch