MLPAB-1552: Remove optional flags from ATTORNEY_SIGN email and channel #181
Conversation
…SIGN email and channel
| Field("/channel", &data.Channel, parse.Validate(func() []shared.FieldError { | ||
| return validate.IsValid("", data.Channel) | ||
| }), parse.Optional()). | ||
| Field("/email", &data.Email, parse.Optional()). |
There was a problem hiding this comment.
you'll want to keep this optional
There was a problem hiding this comment.
We will always expect an email via the online channel...are you referring to this event listener being used for paper attorneys via scanning?
There was a problem hiding this comment.
https://github.com/ministryofjustice/opg-modernising-lpa/pull/1200/files#diff-75a2c79a05d59597c29f665f8d24662c63e9ac5e83bdae3eff8de38a0067920dR150 but it will only be sent when it changes
lambda/update/parse/changes.go
Outdated
| } | ||
|
|
||
| // Changes constructs a new [Parser] for a set of changes. | ||
| func Changes(changes []shared.Change) *Parser { | ||
| func Changes(changes []shared.Change, lpa *shared.Lpa) *Parser { |
There was a problem hiding this comment.
what is the purpose of passing lpa in here?
There was a problem hiding this comment.
I kept getting a null-valued lpa when accessing it from within the closures so I needed a way to pass it down through the chained functions. I think what was actually happening was debug in Goland was only showing values there if it was accessed in code as everything is working referencing the lpa directly.
I'll revert this 👍
lambda/update/attorney_sign.go
Outdated
| @@ -43,18 +43,27 @@ func validateAttorneySign(changes []shared.Change) (AttorneySign, []shared.Field | |||
| } | |||
|
|
|||
| data.Index = &i | |||
| data.Mobile = p.Lpa.Attorneys[i].Mobile | |||
There was a problem hiding this comment.
couldn't this be lpa.Attorneys[i].Mobile?
acsauk
deleted the
MLPAB-1552-enforce-existing-values-match-old-remove-optional
branch
Fixes MLPAB-1552