Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2088: Make email optional, channel required for create trust corporation #188

Merged
merged 2 commits into from
May 1, 2024

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented May 1, 2024

Partially fixes MLPAB-2088. As part of the MRLPA work we will be making email an optional field for trust corps so we can infer the channel.

I'll come back and uncomment the validation for channel + email once consumer tests are updated.

@acsauk acsauk temporarily deployed to 188mlpab208 May 1, 2024 13:16 — with GitHub Actions Inactive
@acsauk acsauk changed the title MLPAB-2088: Make email required for online only MLPAB-2088: Make email optional, channel required for create trust corporation May 1, 2024
@acsauk acsauk marked this pull request as ready for review May 1, 2024 13:27
@acsauk acsauk requested a review from a team as a code owner May 1, 2024 13:27
Copy link
Contributor

@hawx hawx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you do the next PR here, it would be good to update validateAttorney to check channel and email too

@acsauk acsauk merged commit 989c8e8 into main May 1, 2024
23 checks passed
@acsauk acsauk deleted the MLPAB-2088-make-trust-corp-email-optional branch May 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants