Don't enforce validation on paper-channel LPAs #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't kick back a 400 response to the scanners because they can't change what they send, so log and accept the validation errors. Plus fix an existing bug with unmarshalling empty dates. For CTC-146 #patch
hawx
reviewed
May 9, 2024
| problem := shared.ProblemInvalidRequest | ||
| problem.Errors = errs | ||
| if input.Channel == shared.ChannelPaper { | ||
| l.logger.Info("encountered validation errors in lpa", slog.Any("uid", uid)) |
There was a problem hiding this comment.
what is the slightly longer term plan for these errors? are we going to store them on the document like sirius does now?
There was a problem hiding this comment.
Still working on that a bit. We know Sirius will need to do validation too, moreso than any done here, to direct caseworkers to anything that needs attention (e.g. R&C != "" is valid, but needs review).
In a perfect world we'd capture these errors and forward them to Sirius (probably through an event) to turn into tasks, but I'm not sure how compatible depending on Sirius's implementation.
Once we get the list of (business-focussed) validation errors through and start speccing up the Sirius work, we can check how we can tie them together.
hawx
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't kick back a 400 response to the scanners because they can't change what they send, so log and accept the validation errors.
Plus fix an existing bug with unmarshalling empty dates.
For CTC-146 #patch