Support image-based R&C for Paper LPAs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gregtyler
force-pushed
the
CTC-146-support-rc-images-for-paper-lpas
branch
from
a375a54 to
82daaa9
Compare
- Alter schema to change fields available based on form channel - Add `FileUpload` and `File` struct types - `FileUpload` is used in submissions, `File` is used to pass back - Add `S3Client.UploadFile` to copy base64-encoded files into S3 - On submission of Paper LPAs, store `FileUpload` objects in S3 and return a reference to them in `File` - Update the fixtures UI to support uploads - Fixed some misplaced if/then/else statements in the JSONSchema For CTC-146 #minor
gregtyler
force-pushed
the
CTC-146-support-rc-images-for-paper-lpas
branch
from
82daaa9 to
eab1525
Compare
acsauk
reviewed
May 13, 2024
internal/objectstore/client.go
Outdated
| } | ||
|
|
||
| hash := sha256.New() | ||
| hash.Write(imgData) |
There was a problem hiding this comment.
Should we be handling the (potential) error returned here?
There was a problem hiding this comment.
Yep, I somehow missed that that could return an error. Handled now.
| if data.Channel == shared.ChannelPaper && len(input.RestrictionsAndConditionsImages) > 0 { | ||
| data.RestrictionsAndConditionsImages = make([]shared.File, len(input.RestrictionsAndConditionsImages)) | ||
| for i, image := range input.RestrictionsAndConditionsImages { | ||
| path := fmt.Sprintf("%s/scans/rc_%d_%s", data.Uid, i, image.Filename) |
There was a problem hiding this comment.
Are we ever likely to get identical filenames?
There was a problem hiding this comment.
I think the inclusion of i should prevent that, since {uid}/scans/rc_{i} should itself be a unique identifier.
There was a problem hiding this comment.
Ah, missed that! All good then 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUploadandFilestruct typesFileUploadis used in submissions,Fileis used to pass backS3Client.UploadFileto copy base64-encoded files into S3FileUploadobjects in S3 and return a reference to them inFileFor CTC-146 #minor