Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JWT secret and change the port on fixtures service #patch #270

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ndasmoj
Copy link
Contributor

@ndasmoj ndasmoj commented Oct 22, 2024

Purpose

This PR updates the JWT secret across the LPA Store so that it matches the JWT secret being sent from Sirius thereby allowing a local setup between both without any manual updates to the JWT secret key.

Approach

Everywhere where the old JWT secret is being used has been replaced with the new one.

Learning

There is a file - opg-data-lpa-store/terraform/account/kms_key_jwt_secret.tf. I am unsure about whether a change is needed in the section below in BOLD or whether its just a description text -


module "jwt_kms" {
  source                  = "../modules/kms_key"
  **encrypted_resource      = "jwt key secret"**
  kms_key_alias_name      = "${data.aws_default_tags.default.tags.application}/${data.aws_default_tags.default.tags.account}/jwt-key"
  enable_key_rotation     = true
  enable_multi_region     = true
  deletion_window_in_days = 10
  kms_key_policy          = data.aws_default_tags.default.tags.account == "development" ? data.aws_iam_policy_document.jwt_kms_merged.json : data.aws_iam_policy_document.jwt_kms.json
  providers = {
    aws.eu_west_1 = aws.management_eu_west_1
    aws.eu_west_2 = aws.management_eu_west_2
  }
}

@ndasmoj ndasmoj requested review from a team as code owners October 22, 2024 13:16
Copy link

@ndasmoj ndasmoj merged commit 5791938 into main Oct 22, 2024
24 checks passed
@ndasmoj ndasmoj deleted the lpa-store-config-patches branch October 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants