VEGA-2500 : Handle manual change to cancelled status #minor #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gregtyler
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR covers VEGA-2500
The PR change adds new rules to the OPG_STATUS_CHANGE change type to include the manual case status update to the 'Cancelled' status. The tests have been updated.
Approach
The logic checks the old values and new values to ensure that they conform to the business rules for changing the status manually to 'Cancelled' and also ensures that the existing logic around the manual case status update to 'Cannot Register' still continues to work.
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the service