Build more LPA Schema #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add basic donor and attorney details to the LPA schema - Add an example LPA - Update tests to use new LPAs - Update handlers to handle and validate new LPA structure For VEGA-2134 #major
gregtyler
had a problem deploying
to
56vega2134b
GitHub Actions
Failure
Also update dependency files #patch
gregtyler
force-pushed
the
VEGA-2134-build-lpa-schema
branch
from
1512935 to
cb376c5
Compare
gregtyler
had a problem deploying
to
56vega2134b
GitHub Actions
Failure
AWS can only operate a single file, and this gives us an opportunity to co-locate the schemas rather than using `$defs`. #patch
gregtyler
force-pushed
the
VEGA-2134-build-lpa-schema
branch
from
cb376c5 to
b4ba3ac
Compare
gregtyler
temporarily deployed
to
56vega2134b
GitHub Actions
Inactive
I somehow removed this in a previous commit #patch
gregtyler
temporarily deployed
to
56vega2134b
GitHub Actions
Inactive
gregtyler
temporarily deployed
to
56vega2134b
GitHub Actions
Inactive
mattmachell
reviewed
Nov 20, 2023
gregtyler
temporarily deployed
to
56vega2134b
GitHub Actions
Inactive
GemTay
reviewed
Nov 22, 2023
GemTay
reviewed
Nov 22, 2023
lambda/shared/person.go
Outdated
|
|
||
| type Donor struct { | ||
| Person | ||
| OtherNames string `json:"otherNames" dynamodbav:""` |
There was a problem hiding this comment.
Just curious why we have an other names field? I thought the decision was to just stick with firstnames & last name?
There was a problem hiding this comment.
I believe this is for "other names known by", like if you're called Elizabeth but everyone calls you Betty. Edit: yep, confirmed that with MRLPA
There was a problem hiding this comment.
Worth making the field more precisely named, to avoid that confusion next time?
There was a problem hiding this comment.
@mattmachell @GemTay Good point! I've changed it to otherNamesKnownBy, is that more helpful?
GemTay
previously approved these changes
Nov 22, 2023
GemTay
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For VEGA-2134 #major