MLPAB-1638 Add update for when certificate provider signs #81
Conversation
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
cb93b36 to
eefa788
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
eefa788 to
3c89ca2
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
3c89ca2 to
7ace6e8
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
7ace6e8 to
16e3173
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
16e3173 to
71145a4
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
71145a4 to
fde3a7d
Compare
hawx
changed the title
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
fde3a7d to
e513d4f
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
2 times, most recently
from
dbce62a to
05f20c8
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
05f20c8 to
1b70f73
Compare
| }) | ||
| } | ||
|
|
||
| _, err = pointer.Set(lpa, change.New) |
There was a problem hiding this comment.
this would need to know the type it is going to set (if you want to see why the current one breaks, try setting /signedAt), so I've removed in favour of having a specific Apply object that does know what the types are
There was a problem hiding this comment.
Makes sense, thanks for reworking that
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
1b70f73 to
bbbdf1a
Compare
internal/shared/person.go
Outdated
| @@ -9,6 +11,10 @@ type Address struct { | |||
| Country string `json:"country"` | |||
| } | |||
|
|
|||
| func (a Address) IsSet() bool { | |||
There was a problem hiding this comment.
This is such a nit, but might be clearer to define IsZero() and check the inverse since "zero" already has clear meaning in Go (arguably person.Address = Address{} would be "set" even though it's empty).
There was a problem hiding this comment.
cool, and it matches time.Time then which is nice
lambda/update/main.go
Outdated
| verifier interface { | ||
| VerifyHeader(events.APIGatewayProxyRequest) bool | ||
| } |
There was a problem hiding this comment.
In the other lambdas this is still verifier shared.JWTVerifier, did this one need to be changed?
There was a problem hiding this comment.
Yeah, because I wanted to inject a mock version in the tests. I'll name the type though to make it look nicer
| }) | ||
| } | ||
|
|
||
| _, err = pointer.Set(lpa, change.New) |
There was a problem hiding this comment.
Makes sense, thanks for reworking that
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
bbbdf1a to
2bb18a3
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
2bb18a3 to
9ce8afe
Compare
hawx
force-pushed
the
MLPAB-1638-certificate-provider
branch
from
9ce8afe to
50c4e9d
Compare
No description provided.