Marshal the shared.Date time value #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawx
force-pushed
the
store-the-time-for-dates
branch
from
7d37335 to
a8c7def
Compare
hawx
force-pushed
the
store-the-time-for-dates
branch
2 times, most recently
from
e6156fb to
b334938
Compare
Currently only IsMalformed is being stored in Dynamo, as it only uses named fields. Since a shared.Date where IsMalformed is true will give an error to whatever is creating it I have chosen to Marshal as a date string.
hawx
force-pushed
the
store-the-time-for-dates
branch
from
b334938 to
5ab9e28
Compare
gregtyler
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing I noticed that date of birth wasn't being stored. I've added a custom marshal for dynamo here so it will, and ignore the IsMalformed field.