MLPAB-1531 Add when certificate provider not related was confirmed to Lpa #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawx
force-pushed
the
MLPAB-1531-send-not-related-confirmation
branch
from
5e0be13 to
5b7a0d0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hawx
force-pushed
the
MLPAB-1531-send-not-related-confirmation
branch
from
5b7a0d0 to
1ed7aae
Compare
hawx
force-pushed
the
MLPAB-1531-send-not-related-confirmation
branch
from
1ed7aae to
f64a7db
Compare
gregtyler
reviewed
Jan 26, 2024
internal/validate/validate.go
Outdated
| return nil | ||
| } | ||
|
|
||
| return If(t.IsZero(), []shared.FieldError{{Source: source, Detail: "field is required"}}) |
There was a problem hiding this comment.
This feels a bit misleading, since the field isn't actually required. Could we use something like "field must be a valid date/time"?
hawx
force-pushed
the
MLPAB-1531-send-not-related-confirmation
branch
from
f64a7db to
ed3670a
Compare
gregtyler
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.