Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3042 add other names (also known as) field #96

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Nov 6, 2023

Purpose

Exposes the "Also known as" field (othernames) so it is accessible for use an LPA. PR in Sirius to update the API endpoint.

For UML-3042

Approach

I added it everywhere middlenames is set.

In order to be able to run make setup-all:

  • Updated pact image to run on M1 machine
  • Updated dockerfile to
    • upgrade pip before running pip install
    • mock-sirius Dockerfile upgraded from python 3.6 to python 3.8 in line with the Dockerfile in lambda-functions
  • Updated requirements files to be consistent with pinned versions across mock-sirius and lambda-functions

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
    • N/A
  • I have updated documentation where relevant
    • N/A
  • I have added tests to prove my work
  • I have run the integration tests (results below)
    • Could not run

docker-compose.yml Outdated Show resolved Hide resolved
@MishNajam MishNajam force-pushed the UML-3042-expose-also-known-as-field branch from 1dfc044 to b790e24 Compare November 13, 2023 14:46
@MishNajam MishNajam merged commit c82e92a into main Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants