Skip to content

Commit

Permalink
Going directly to an incident page does not take you through the logi…
Browse files Browse the repository at this point in the history
…n journey (#64)

* Fix login URL

Needs a leading slash or it's treated as relative

* Replace sign out link with context

You can't sign out and you can only disconnect through GitHub, so no point having a link that implies otherwise
  • Loading branch information
gregtyler authored Dec 4, 2020
1 parent 75e5ef7 commit 0425bc2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion opgincidentresponse/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def get_env_var(setting, warn_only=False):
PAGERDUTY_SERVICE = get_env_var("PAGERDUTY_SERVICE")
PAGERDUTY_EMAIL = get_env_var("PAGERDUTY_EMAIL")

LOGIN_URL = "login/github-org"
LOGIN_URL = "/login/github-org"

# Whether to use https://pypi.org/project/bleach/ to strip potentially dangerous
# HTML input in string fields
Expand Down
4 changes: 2 additions & 2 deletions opgincidentresponse/templates/govuk_base.html
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@
></image>
</svg>

<a class="moj-header__link moj-header__link--service-name" href="#">OPG Incident Response</a>
<a class="moj-header__link moj-header__link--service-name" href="/">OPG Incident Response</a>
</div>
<div class="moj-header__content">

<nav class="moj-header__navigation" aria-label="Account navigation">

<ul class="moj-header__navigation-list">
<li class="moj-header__navigation-item">
<a class="moj-header__navigation-link" href="#">Sign out</a>
Signed in via GitHub as <strong>{{ backends.associated.first }}</strong>
</li>
</ul>

Expand Down

0 comments on commit 0425bc2

Please sign in to comment.