Merge pull request #1691 from ministryofjustice/MLPAB-2689-show-cp-da…

…shcard-when-signed-but-no-id MLPAB-2689: Show dashboard certificate providers until certificate provided and identity confirmed
ministryofjustice · Dec 19, 2024 · 229f255 · 229f255
2 parents 50174ae + 6e9b6be
commit 229f255
Show file tree

Hide file tree

Showing 5 changed files with 88 additions and 13 deletions.
diff --git a/cypress/e2e/certificate-provider/dashboard.cy.js b/cypress/e2e/certificate-provider/dashboard.cy.js
@@ -0,0 +1,51 @@
+describe('Dashboard', () => {
+    context('confirmed identity', () => {
+        it('shows the certificate provider card', () => {
+            cy.visit('/fixtures/certificate-provider?redirect=/task-list&progress=confirmYourIdentity');
+
+            cy.contains('li', 'Confirm your details').should('contain', 'Completed');
+            cy.contains('li', 'Confirm your identity').should('contain', 'Completed');
+            cy.contains('li', 'Provide your certificate').should('contain', 'Not started');
+
+            cy.visit('/dashboard')
+
+            cy.contains('I’m a certificate provider').click()
+            cy.contains('Property and affairs');
+            cy.contains('Sam Smith');
+            cy.contains('strong', 'In progress');
+            cy.contains('a', 'Go to task list')
+        })
+    })
+
+    context('provided certificate', () => {
+        it('does not show the certificate provider card', () => {
+            cy.visit('/fixtures/certificate-provider?redirect=/task-list&progress=provideYourCertificate');
+
+            cy.contains('li', 'Confirm your details').should('contain', 'Completed');
+            cy.contains('li', 'Confirm your identity').should('contain', 'Completed');
+            cy.contains('li', 'Provide your certificate').should('contain', 'Completed');
+
+            cy.visit('/dashboard')
+
+            cy.contains('I’m a certificate provider').should('not.exist')
+        })
+    })
+
+    context('provided certificate but identity mismatch', () => {
+        it('shows the certificate provider card', () => {
+            cy.visit('/fixtures/certificate-provider?redirect=/task-list&progress=provideYourCertificate&idStatus=mismatch');
+
+            cy.contains('li', 'Confirm your details').should('contain', 'Completed');
+            cy.contains('li', 'Confirm your identity').should('contain', 'Pending');
+            cy.contains('li', 'Provide your certificate').should('contain', 'Completed');
+
+            cy.visit('/dashboard')
+
+            cy.contains('I’m a certificate provider').click()
+            cy.contains('Property and affairs');
+            cy.contains('Sam Smith');
+            cy.contains('strong', 'In progress');
+            cy.contains('a', 'Go to task list')
+        })
+    })
+})
diff --git a/internal/dashboard/store.go b/internal/dashboard/store.go
@@ -206,7 +206,7 @@ func (s *Store) GetAll(ctx context.Context) (results dashboarddata.Results, err
 
 			lpaID := certificateProviderProvidedDetails.LpaID
 
-			if !certificateProviderProvidedDetails.SignedAt.IsZero() {
+			if !certificateProviderProvidedDetails.SignedAt.IsZero() && certificateProviderProvidedDetails.Tasks.ConfirmYourIdentity.IsCompleted() {
 				delete(certificateProviderMap, lpaID)
 			}
 

diff --git a/internal/dashboard/store_test.go b/internal/dashboard/store_test.go
@@ -105,6 +105,7 @@ func TestDashboardStoreGetAll(t *testing.T) {
 		SK:       dynamo.CertificateProviderKey(sessionID),
 		LpaID:    "signed-by-cp",
 		SignedAt: time.Now(),
+		Tasks:    certificateproviderdata.Tasks{ConfirmYourIdentity: task.IdentityStateCompleted},
 	}
 	lpaReferenced := &lpadata.Lpa{LpaID: "referenced", LpaUID: "X"}
 	lpaReferencedLink := map[string]any{

diff --git a/internal/page/fixtures/certificate_provider.go b/internal/page/fixtures/certificate_provider.go
@@ -45,6 +45,7 @@ func CertificateProvider(
 		"signedByDonor",
 		"confirmYourDetails",
 		"confirmYourIdentity",
+		"provideYourCertificate",
 	}
 
 	return func(appData appcontext.Data, w http.ResponseWriter, r *http.Request) error {
@@ -62,6 +63,7 @@ func CertificateProvider(
 			useRealUID                        = r.FormValue("uid") == "real"
 			donorChannel                      = r.FormValue("donorChannel")
 			isSupported                       = r.FormValue("is-supported") == "1"
+			idStatus                          = r.FormValue("idStatus")
 		)
 
 		if certificateProviderSub == "" {
@@ -269,14 +271,35 @@ func CertificateProvider(
 		}
 
 		if progress >= slices.Index(progressValues, "confirmYourIdentity") {
-			certificateProvider.IdentityUserData = identity.UserData{
-				Status:      identity.StatusConfirmed,
-				CheckedAt:   time.Now(),
-				FirstNames:  donorDetails.CertificateProvider.FirstNames,
-				LastName:    donorDetails.CertificateProvider.LastName,
-				DateOfBirth: certificateProvider.DateOfBirth,
+			var userData identity.UserData
+
+			switch idStatus {
+			case "mismatch":
+				userData = identity.UserData{
+					Status:      identity.StatusConfirmed,
+					CheckedAt:   time.Now(),
+					FirstNames:  "a",
+					LastName:    "b",
+					DateOfBirth: certificateProvider.DateOfBirth,
+				}
+				certificateProvider.Tasks.ConfirmYourIdentity = task.IdentityStatePending
+			default:
+				userData = identity.UserData{
+					Status:      identity.StatusConfirmed,
+					CheckedAt:   time.Now(),
+					FirstNames:  donorDetails.CertificateProvider.FirstNames,
+					LastName:    donorDetails.CertificateProvider.LastName,
+					DateOfBirth: certificateProvider.DateOfBirth,
+				}
+				certificateProvider.Tasks.ConfirmYourIdentity = task.IdentityStateCompleted
 			}
-			certificateProvider.Tasks.ConfirmYourIdentity = task.IdentityStateCompleted
+
+			certificateProvider.IdentityUserData = userData
+		}
+
+		if progress >= slices.Index(progressValues, "provideYourCertificate") {
+			certificateProvider.SignedAt = time.Now()
+			certificateProvider.Tasks.ProvideTheCertificate = task.StateCompleted
 		}
 
 		if err := certificateProviderStore.Put(certificateProviderCtx, certificateProvider); err != nil {

diff --git a/web/template/dashboard.gohtml b/web/template/dashboard.gohtml
@@ -51,7 +51,7 @@
                     <a class="govuk-button govuk-button--secondary" href="{{ link .App (global.Paths.Progress.Format .Item.Lpa.LpaID) }}">{{ tr .App "trackLpa" }}</a>
                 </div>
             {{ else if .Item.Lpa.Status.IsRegistered }}
-                
+
             {{ else if .Item.Lpa.Status.IsStatutoryWaitingPeriod }}
                 <div class="govuk-button-group">
                     <a class="govuk-button" href="{{ link .App (global.Paths.ViewLPA.Format .Item.Lpa.LpaID) }}">{{ tr .App "viewLpa" }}</a>
@@ -150,7 +150,7 @@
                 <span class="govuk-!-font-weight-regular">{{ .Item.Lpa.Donor.FullName }}</span>
             </h3>
             <div>
-                {{ if and .Item.CertificateProvider.Tasks.ReadTheLpa.IsCompleted (not .Item.Lpa.SignedAt.IsZero) .Item.Lpa.Tasks.PayForLpa.IsCompleted }}
+                {{ if and .Item.CertificateProvider.Tasks.ReadTheLpa.IsCompleted (not .Item.Lpa.SignedAt.IsZero) .Item.Lpa.Paid .Item.CertificateProvider.Tasks.ConfirmYourIdentity.IsCompleted }}
                     <strong class="app-tag govuk-tag--yellow">{{ tr .App "readyToSign" }}</strong>
                 {{ else }}
                     <strong class="app-tag govuk-tag--blue">{{ tr .App "inProgress" }}</strong>
@@ -285,7 +285,7 @@
                                 {{ tr .App "theLpasNamedAsAttorneyHaveSuccessfullyRegistered" }}
                             {{ end }}
                         </p>
-                        
+
                         {{ range .AttorneyLpas }}
                             {{ template "attorneyCard" (card $.App .) }}
                         {{ end }}
@@ -333,9 +333,9 @@
                         {{ range .VoucherLpas }}
                             {{ template "voucherCard" (card $.App .) }}
                         {{ end }}
-                        {{ if .NeedsTabs }}</div>{{ end }}                    
+                        {{ if .NeedsTabs }}</div>{{ end }}
                 {{ end }}
-                
+
                 {{ if .NeedsTabs }}</div>{{ end }}
         </div>
     </div>