MLPAB-1335 Remove "who is the lpa for" page (#715)

.github/workflows/go-unit-tests.yml

@@ -56,10 +56,7 @@ jobs:
 
       - name: Run tests and generate coverage report
         run: |
-          mkdir -p ./coverage/cmd ./coverage/internal
-          go test -cover ./internal/... -args -test.gocoverdir="$PWD/coverage/cmd"
-          go test -cover ./internal/... -args -test.gocoverdir="$PWD/coverage/internal"
-          go tool covdata textfmt -i=./coverage/internal,./coverage/cmd -o ./coverage/coverage_combined.out
+          make go-test
 
       - name: Publish pacts
         run: |
@@ -75,4 +72,4 @@ jobs:
         uses: codecov/codecov-action@v3
         with:
           flags: unittests
-          files: ./coverage/coverage_combined.out
+          files: ./coverage.out

Makefile

@@ -24,10 +24,10 @@ help: ##@other Show this help.
 	@perl -e '$(HELP_FUN)' $(MAKEFILE_LIST)
 
 go-test: ##@testing Runs full go test suite
-	find . -name go.mod -execdir go test ./... -race -covermode=atomic -coverprofile=coverage.out \;
+	go test ./... -race -covermode=atomic -coverprofile=coverage.out
 
 go-generate: ##@testing Runs go generate
-	find . -name go.mod -execdir go generate ./... \;
+	go generate ./...
 
 coverage: ##@testing Produces coverage report and launches browser line based coverage explorer. To test a specific internal package pass in the package name e.g. make coverage package=page
 ifdef package

cypress/e2e/donor/your-address.cy.js

@@ -1,4 +1,4 @@
-import {AddressFormAssertions} from "../../support/e2e";
+import { AddressFormAssertions } from "../../support/e2e";
 
 describe('Donor address', () => {
     beforeEach(() => {
@@ -7,17 +7,17 @@ describe('Donor address', () => {
 
     it('address can be looked up', () => {
         AddressFormAssertions.assertCanAddAddressFromSelect()
-        cy.url().should('contain', '/who-is-the-lpa-for');
+        cy.url().should('contain', '/lpa-type');
     });
 
     it('address can be entered manually if not found', () => {
         AddressFormAssertions.assertCanAddAddressManually('I can’t find my address in the list')
-        cy.url().should('contain', '/who-is-the-lpa-for');
+        cy.url().should('contain', '/lpa-type');
     });
 
     it('address can be entered manually on invalid postcode', () => {
         AddressFormAssertions.assertCanAddAddressManually('Enter address manually', true)
-        cy.url().should('contain', '/who-is-the-lpa-for');
+        cy.url().should('contain', '/lpa-type');
     });
 
     it('errors when empty postcode', () => {

internal/page/data.go

@@ -116,8 +116,6 @@ type Lpa struct {
 	AttorneyDecisions actor.AttorneyDecisions
 	// The certificate provider named in the LPA
 	CertificateProvider actor.CertificateProvider
-	// Who the LPA is being drafted for (set, but not used)
-	WhoFor string
 	// Type of LPA being drafted
 	Type LpaType
 	// ApplicationReason is why the application is being made

internal/page/donor/certificate_provider_address_test.go

@@ -198,7 +198,6 @@ func TestPostCertificateProviderAddressManualFromStore(t *testing.T) {
 				FirstNames: "John",
 				Address:    testAddress,
 			},
-			WhoFor: "me",
 		}).
 		Return(nil)
 
@@ -208,7 +207,6 @@ func TestPostCertificateProviderAddressManualFromStore(t *testing.T) {
 			FirstNames: "John",
 			Address:    place.Address{Line1: "abc"},
 		},
-		WhoFor: "me",
 	})
 	resp := w.Result()
 

internal/page/donor/choose_attorneys_address_test.go

@@ -295,7 +295,6 @@ func TestPostChooseAttorneysAddressManualFromStore(t *testing.T) {
 				FirstNames: "John",
 				Address:    testAddress,
 			}}},
-			WhoFor: "me",
 		}).
 		Return(nil)
 
@@ -306,7 +305,6 @@ func TestPostChooseAttorneysAddressManualFromStore(t *testing.T) {
 			FirstNames: "John",
 			Address:    place.Address{Line1: "abc"},
 		}}},
-		WhoFor: "me",
 	})
 	resp := w.Result()
 

internal/page/donor/choose_replacement_attorneys_address_test.go

@@ -260,8 +260,7 @@ func TestPostChooseReplacementAttorneysAddressManualFromStore(t *testing.T) {
 				FirstNames: "John",
 				Address:    testAddress,
 			}}},
-			WhoFor: "me",
-			Tasks:  page.Tasks{ChooseReplacementAttorneys: actor.TaskCompleted},
+			Tasks: page.Tasks{ChooseReplacementAttorneys: actor.TaskCompleted},
 		}).
 		Return(nil)
 
@@ -272,7 +271,6 @@ func TestPostChooseReplacementAttorneysAddressManualFromStore(t *testing.T) {
 			FirstNames: "John",
 			Address:    place.Address{Line1: "abc"},
 		}}},
-		WhoFor: "me",
 	})
 	resp := w.Result()
 

internal/page/donor/enter_replacement_trust_corporation_address_test.go

@@ -174,7 +174,6 @@ func TestPostEnterReplacementTrustCorporationAddressManualFromStore(t *testing.T
 				Name:    "John",
 				Address: testAddress,
 			}},
-			WhoFor: "me",
 		}).
 		Return(nil)
 
@@ -184,7 +183,6 @@ func TestPostEnterReplacementTrustCorporationAddressManualFromStore(t *testing.T
 			Name:    "John",
 			Address: place.Address{Line1: "abc"},
 		}},
-		WhoFor: "me",
 	})
 	resp := w.Result()
 

internal/page/donor/enter_trust_corporation_address_test.go

@@ -174,7 +174,6 @@ func TestPostEnterTrustCorporationAddressManualFromStore(t *testing.T) {
 				Name:    "John",
 				Address: testAddress,
 			}},
-			WhoFor: "me",
 		}).
 		Return(nil)
 
@@ -184,7 +183,6 @@ func TestPostEnterTrustCorporationAddressManualFromStore(t *testing.T) {
 			Name:    "John",
 			Address: place.Address{Line1: "abc"},
 		}},
-		WhoFor: "me",
 	})
 	resp := w.Result()
 

internal/page/donor/register.go

@@ -189,8 +189,6 @@ func Register(
 		YourDetails(tmpls.Get("your_details.gohtml"), donorStore, sessionStore))
 	handleWithLpa(page.Paths.YourAddress, None,
 		YourAddress(logger, tmpls.Get("your_address.gohtml"), addressClient, donorStore))
-	handleWithLpa(page.Paths.WhoIsTheLpaFor, None,
-		WhoIsTheLpaFor(tmpls.Get("who_is_the_lpa_for.gohtml"), donorStore))
 	handleWithLpa(page.Paths.LpaType, None,
 		LpaType(tmpls.Get("lpa_type.gohtml"), donorStore))
 	handleWithLpa(page.Paths.ApplicationReason, None,