Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2269 - add toggle for waf alb association and protect mocks #1339

Merged

Conversation

andrewpearce-digital
Copy link
Contributor

Purpose

Support turning of WAF association for ITHC

Fixes MLPAB-2269

Approach

  • Add variable to toggle WAF ALB association per environment
  • protect mock pay and mock onelogin ALBs with WAF

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review July 9, 2024 16:40
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner July 9, 2024 16:40
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (4c3594c) to head (c56ad27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files         220      220           
  Lines       10779    10779           
=======================================
  Hits        10201    10201           
  Misses        422      422           
  Partials      156      156           
Flag Coverage Δ
unittests 94.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(on the assumption the idea is we disable the WAF for ITHC)

@andrewpearce-digital andrewpearce-digital merged commit 5c3e6a2 into main Jul 9, 2024
28 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2269-toggle-waf-for-preproduction-environment branch July 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants