Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1901 Add voucher enter reference page #1418

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Aug 9, 2024

I've put a very terrible fixtures page in for now, just until we get to the tickets that send the code

@hawx hawx self-assigned this Aug 9, 2024
@hawx hawx requested a review from a team as a code owner August 9, 2024 13:33
internal/voucher/path.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 95.27027% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.08%. Comparing base (f078924) to head (037d3bc).

Files Patch % Lines
internal/dashboard/store.go 50.00% 2 Missing ⚠️
internal/donor/store.go 81.81% 2 Missing ⚠️
internal/voucher/voucherpage/task_list.go 33.33% 1 Missing and 1 partial ⚠️
internal/dynamo/keys.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
+ Coverage   95.03%   95.08%   +0.04%     
==========================================
  Files         246      251       +5     
  Lines       11070    11201     +131     
==========================================
+ Hits        10520    10650     +130     
  Misses        394      394              
- Partials      156      157       +1     
Flag Coverage Δ
unittests 95.08% <95.27%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hawx hawx had a problem deploying to dev_1418mlpab19 August 9, 2024 14:01 — with GitHub Actions Failure
@hawx hawx force-pushed the MLPAB-1901-voucher-login branch from 6761f1d to 19c57f8 Compare August 9, 2024 14:13
@hawx hawx had a problem deploying to dev_1418mlpab19 August 9, 2024 14:30 — with GitHub Actions Failure
@hawx hawx temporarily deployed to dev_1418mlpab19 August 12, 2024 07:08 — with GitHub Actions Inactive
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hawx hawx merged commit 455b7de into main Aug 12, 2024
28 checks passed
@hawx hawx deleted the MLPAB-1901-voucher-login branch August 12, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants