Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2318: Send attorney opt out to lpa-store #1419

Merged
merged 13 commits into from
Aug 13, 2024

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented Aug 9, 2024

Purpose

Fixes MLPAB-2318

Also includes a small fix to some mocks. As we're dropping mocks before generating them I encountered a couple of issues:

  • We didn't have an interface for sessions.CookieStore so weren't regenerating it
  • We weren't using the mock for LpaResolvingService

(and Dockerfile changes to fix a casing mismatch warning)

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (455b7de) to head (f69b312).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         251      251           
  Lines       11201    11209    +8     
=======================================
+ Hits        10650    10658    +8     
  Misses        394      394           
  Partials      157      157           
Flag Coverage Δ
unittests 95.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acsauk acsauk temporarily deployed to dev_1419mlpab23 August 12, 2024 13:16 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_1419mlpab23 August 12, 2024 15:43 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_1419mlpab23 August 12, 2024 16:12 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_1419mlpab23 August 12, 2024 16:49 — with GitHub Actions Inactive
@acsauk acsauk marked this pull request as ready for review August 12, 2024 19:28
@acsauk acsauk requested a review from a team as a code owner August 12, 2024 19:28
@acsauk acsauk merged commit e85c900 into main Aug 13, 2024
27 checks passed
@acsauk acsauk deleted the MLPAB-2318-send-attorney-opt-out-to-lpa-store branch August 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants