MLPAB-2626 - remove region from vpc endpoint names/tagging #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpearce-digital
temporarily deployed
to
dev_1598
GitHub Actions
Inactive
andrewpearce-digital
temporarily deployed
to
dev_1598
GitHub Actions
Inactive
andrewpearce-digital
temporarily deployed
to
dev_1598
GitHub Actions
Inactive
andrewpearce-digital
changed the title
andrewpearce-digital
temporarily deployed
to
dev_1598
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 272 272
Lines 15247 15247
=======================================
Hits 14468 14468
Misses 610 610
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hawx
approved these changes
Nov 5, 2024
andrewpearce-digital
deleted the
MLPAB-2626-remove-region-from-resource-names-when-not-needed-in-account-level-terraform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove unnecessary region name (eu-west-1) in resource naming
Fixes MLPAB-2626
Approach
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Modernising LPA service