Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2613 - Fix event received SQS KMC CMK permissions #1660

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Dec 3, 2024

Purpose

The KMS CMK does not have the correct permissions applied as defined in terraform. Recreating and extending permissions with explicit statements should do the trick

Fixes MLPAB-2613

Approach

  • fix key name and replace to ensure correct policy is attached
  • fix statements for services and user
  • allow iam users

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Modernising LPA service

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review December 3, 2024 15:18
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner December 3, 2024 15:18
@andrewpearce-digital andrewpearce-digital merged commit 9eddc9d into main Dec 3, 2024
22 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2613-fix-er-sqs-cmk branch December 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants