Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2748 - Check egress via network firewall #1678

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

andrewpearce-digital
Copy link
Contributor

Purpose

Ensure that requests not permitted by the allow list are dropped

Fixes MLPAB-2748

Approach

  • write a script to make a request for an address not on the allow list
  • build an egress checker image
  • TODO: deploy lambda function to check egress

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Modernising LPA service

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (ed9f258) to head (111e7d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         284      284           
  Lines       15910    15910           
=======================================
  Hits        15110    15110           
  Misses        630      630           
  Partials      170      170           
Flag Coverage Δ
unittests 94.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant