Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2818 - update lambda runtime interface emulator #1750

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Jan 30, 2025

Purpose

We no longer use the RIE, or the dev docker build targets, so we need to remove it. I will leave instructions for obtaining and mounting the RIE if needed later in a way that keeps it out of the docker build.

Fixes MLPAB-2818

Approach

  • Add instructions for using the RIE when needed.
  • remove dev docker build target for schedule-runner and event-received
  • remove binary for Lambda RIE

@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review January 30, 2025 16:31
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner January 30, 2025 16:31
hawx
hawx previously approved these changes Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (e8d1b3a) to head (a8617b7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1750   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         286      286           
  Lines       16641    16641           
=======================================
  Hits        15825    15825           
  Misses        644      644           
  Partials      172      172           
Flag Coverage Δ
unittests 95.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpearce-digital andrewpearce-digital merged commit 6c002b1 into main Jan 31, 2025
31 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2818-keep-aws-lambda-rie-up-to-date branch January 31, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants