Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLPAB-1284 Use details from the latest LPA to populate your-details page #722

Merged
merged 3 commits into from
Sep 25, 2023
Merged

MLPAB-1284 Use details from the latest LPA to populate your-details page #722

merged 3 commits into from
Sep 25, 2023

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Sep 21, 2023

No description provided.

@hawx hawx self-assigned this Sep 21, 2023
@hawx hawx requested a review from a team as a code owner September 21, 2023 10:53
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage is 96.84% of modified lines.

Files Changed Coverage
internal/app/app.go ø
internal/page/attorney/register.go ø
internal/page/certificateprovider/register.go ø
internal/page/common.go ø
internal/page/donor/register.go ø
internal/app/donor_store.go 85.00%
cmd/event-received/main.go 100.00%
internal/app/attorney_store.go 100.00%
internal/app/certificate_provider_store.go 100.00%
internal/app/dashboard_store.go 100.00%
... and 4 more

📢 Thoughts on this report? Let us know!.

@hawx hawx force-pushed the MLPAB-1284-use-latest-lpa branch 2 times, most recently from 100be90 to 9573049 Compare September 21, 2023 13:01
@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@hawx hawx temporarily deployed to dev_722mlpab128 September 21, 2023 13:29 — with GitHub Actions Inactive
@hawx
Use details from the latest LPA to populate your-details page
a5382ee 
This changes the ActorIndex to be (SK, UpdatedAt) so we can query for LPAs by
actor sorted by UpdatedAt. By not setting UpdatedAt until a UID is set we can
filter out LPAs that aren't shown on the dashboard page.

Also renames the dynamo client methods to be more consistent, now they are
prefixed with One or All depending on how many results are returned.
@hawx hawx force-pushed the MLPAB-1284-use-latest-lpa branch from 9573049 to a5382ee Compare September 22, 2023 07:07
@hawx hawx temporarily deployed to dev_722mlpab128 September 22, 2023 07:32 — with GitHub Actions Inactive
@hawx hawx temporarily deployed to dev_722mlpab128 September 25, 2023 07:03 — with GitHub Actions Inactive
@hawx hawx merged commit 1757293 into main Sep 25, 2023
24 checks passed
@hawx hawx deleted the MLPAB-1284-use-latest-lpa branch September 25, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpearce-digital andrewpearce-digital andrewpearce-digital approved these changes

Assignees

@hawx hawx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawx @andrewpearce-digital