MLPAB-1291 Hide submitted replacement attorney cards #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawx
commented
Sep 27, 2023
| @@ -0,0 +1,264 @@ | |||
| package page | |||
There was a problem hiding this comment.
The fixtures/testing-start stuff has become too big. I think this approach of having a per-login actor handler will work better since it can make assumptions about the state of the data.
Also removing the split of the handlers and just having one will remove a lot of annoying duplicated work.
There was a problem hiding this comment.
It's tempting to move it all to internal/page/fixtures/...
There was a problem hiding this comment.
Nice re-work - I'd be happy for this to live in a fixtures package at some point 👍
PR Environment Terraform Plan SummaryPlan: 1 to add, 4 to change, 1 to destroy |
hawx
temporarily deployed
to
dev_732mlpab129
GitHub Actions
Inactive
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
hawx
force-pushed
the
MLPAB-1291-hide-replacement-card-after-registration
branch
from
36d9d6f to
9ef8df7
Compare
And create a brand new fixtures page for attorneys
hawx
force-pushed
the
MLPAB-1291-hide-replacement-card-after-registration
branch
2 times, most recently
from
b60328e to
88ad562
Compare
hawx
force-pushed
the
MLPAB-1291-hide-replacement-card-after-registration
branch
from
88ad562 to
b9558f5
Compare
hawx
deleted the
MLPAB-1291-hide-replacement-card-after-registration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.