Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLPAB-922 Update content on progress tracker #738

Merged
merged 2 commits into from
Oct 10, 2023
Merged

MLPAB-922 Update content on progress tracker #738

merged 2 commits into from
Oct 10, 2023

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Sep 29, 2023 •
edited
Loading

Next PRs:

  • the attorney tracker
  • move donor tests over to the new fixtures

@hawx hawx self-assigned this Sep 29, 2023
@hawx hawx force-pushed the MLPAB-922-progress-content branch 2 times, most recently from 40a6fd8 to 5be63b7 Compare October 9, 2023 09:54
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/actor/attorney_provided.go 100.00% <100.00%> (ø)
internal/actor/certificate_provider_provided.go 100.00% <100.00%> (ø)
internal/app/app.go 86.48% <100.00%> (+0.09%) ⬆️
internal/app/attorney_store.go 100.00% <100.00%> (ø)
internal/dynamo/client.go 92.77% <100.00%> (+0.66%) ⬆️
internal/page/attorney/sign.go 100.00% <100.00%> (ø)
internal/page/donor/lpa_progress.go 85.00% <100.00%> (+1.66%) ⬆️
internal/page/donor/register.go 100.00% <100.00%> (ø)
internal/templatefn/fn.go 94.02% <ø> (-0.18%) ⬇️
internal/page/data.go 91.66% <95.89%> (+0.98%) ⬆️

📢 Thoughts on this report? Let us know!.

@hawx hawx force-pushed the MLPAB-922-progress-content branch 3 times, most recently from 4afe294 to 4b7b983 Compare October 9, 2023 13:22
@hawx hawx force-pushed the MLPAB-922-progress-content branch from 4b7b983 to d5bbb04 Compare October 9, 2023 14:22
@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@hawx hawx temporarily deployed to dev_738mlpab922 October 9, 2023 14:52 — with GitHub Actions Inactive
@hawx hawx marked this pull request as ready for review October 10, 2023 06:54
@hawx hawx requested a review from a team as a code owner October 10, 2023 06:54
acsauk
acsauk reviewed Oct 10, 2023
View reviewed changes
internal/page/fixtures/donor.go
Comment on lines +26 to +40
progressValues := []string{
"provideYourDetails",
"chooseYourAttorneys",
"chooseYourReplacementAttorneys",
"chooseWhenTheLpaCanBeUsed",
"addRestrictionsToTheLpa",
"chooseYourCertificateProvider",
"peopleToNotifyAboutYourLpa",
"checkAndSendToYourCertificateProvider",
"payForTheLpa",
"confirmYourIdentityAndSignTheLpa",
"signedByCertificateProvider",
"signedByAttorneys",
"submitted",
"registered",
Copy link
Contributor

@acsauk acsauk Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 👍

acsauk
acsauk approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hawx hawx merged commit f803f44 into main Oct 10, 2023
23 checks passed
@hawx hawx deleted the MLPAB-922-progress-content branch October 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acsauk acsauk acsauk approved these changes

@andrewpearce-digital andrewpearce-digital andrewpearce-digital approved these changes

Assignees

@hawx hawx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawx @andrewpearce-digital @acsauk