Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1194: Remove unused properties from Types #742

Merged
merged 4 commits into from
Oct 2, 2023
Merged

MLPAB-1194: Remove unused properties from Types #742

merged 4 commits into from
Oct 2, 2023

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented Oct 2, 2023

Purpose

This is mostly removing props from the details a certificate provider enters that we no longer ask for. As we were relying on the names being available on CertificateProviderProvided I've fallen back on getting these from the LPA itself.

Fixes MLPAB-1194

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
internal/actor/certificate_provider_provided.go 100.00% <100.00%> (ø)
...ficateprovider/identity_with_one_login_callback.go 95.23% <100.00%> (+0.32%) ⬆️
...nal/page/certificateprovider/identity_with_todo.go 100.00% <100.00%> (ø)
...nal/page/certificateprovider/identity_with_yoti.go 100.00% <100.00%> (ø)
...certificateprovider/identity_with_yoti_callback.go 100.00% <100.00%> (ø)
internal/page/certificateprovider/register.go 94.33% <100.00%> (ø)
internal/page/data.go 90.68% <ø> (ø)
...l/page/donor/witnessing_as_certificate_provider.go 90.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@acsauk acsauk marked this pull request as ready for review October 2, 2023 12:44
@acsauk acsauk requested a review from a team as a code owner October 2, 2023 12:44
@acsauk acsauk merged commit cb85f83 into main Oct 2, 2023
23 checks passed
@acsauk acsauk deleted the MLPAB-1194 branch October 2, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants