Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1482 - add missing vpc endpoints #760

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

andrewpearce-digital
Copy link
Contributor

Purpose

Direct requests to AWS services via a VPC endpoint to reduce the egress vector through the internet gateway

Fixes MLPAB-1482

Approach

  • create rum endpoint
  • create xray endpoint
  • create execute-api endpoint

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@andrewpearce-digital andrewpearce-digital temporarily deployed to dev_760mlpab148 October 10, 2023 09:12 — with GitHub Actions Inactive
@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review October 10, 2023 09:16
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner October 10, 2023 09:16
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/actor/attorney_provided.go 100.00% <100.00%> (ø)
internal/actor/certificate_provider_provided.go 100.00% <100.00%> (ø)
internal/app/app.go 86.48% <100.00%> (+0.09%) ⬆️
internal/app/attorney_store.go 100.00% <100.00%> (ø)
internal/dynamo/client.go 92.77% <100.00%> (+0.66%) ⬆️
internal/page/attorney/sign.go 100.00% <100.00%> (ø)
internal/page/donor/lpa_progress.go 85.00% <100.00%> (+1.66%) ⬆️
internal/page/donor/register.go 100.00% <100.00%> (ø)
internal/templatefn/fn.go 94.02% <ø> (-0.18%) ⬇️
internal/page/data.go 91.66% <95.89%> (+0.98%) ⬆️

📢 Thoughts on this report? Let us know!.

@andrewpearce-digital andrewpearce-digital merged commit f49ce30 into main Oct 10, 2023
24 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-1482-create-endpoint-for-xray branch October 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants