Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1478 - Use VPC Endpoints #765

Closed
wants to merge 5 commits into from
Closed

MLPAB-1478 - Use VPC Endpoints #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3631e8
add new variable but don't set yet
andrewpearce-digital Oct 11, 2023
c860459
run full suite
andrewpearce-digital Oct 11, 2023
aaac56b
use AWS BAse URL
andrewpearce-digital Oct 11, 2023
300aa16
Merge branch 'main' into MLPAB-1478-configure-app-to-use-vpc-endpoint…
andrewpearce-digital Oct 11, 2023
2f723a0
remove fullstop
andrewpearce-digital Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/workflow_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
run_against_image: false
base_url: "https://${{ needs.pr_deploy.outputs.url }}"
tag: ${{ needs.create_tags.outputs.version_tag }}
smoke: true
smoke: false
environment_config_json: ${{ needs.pr_deploy.outputs.environment_config_json }}
secrets:
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID_ACTIONS }}
Expand Down
5 changes: 5 additions & 0 deletions terraform/environment/region/modules/app/ecs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,11 @@ locals {
name = "EVENT_BUS_NAME",
value = var.event_bus.name
},
{
# use vpc endpoints
name = "AWS_BASE_URL",
value = "https://com.amazonaws.${data.aws_region.current.name}"
},
]
}
)
Expand Down