Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLPAB-1472: Update virus scanning results on evidence in dynamodb #779

Merged
merged 32 commits into from
Oct 24, 2023
Merged

MLPAB-1472: Update virus scanning results on evidence in dynamodb #779

merged 32 commits into from
Oct 24, 2023

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented Oct 17, 2023 •
edited
Loading

Purpose

Fixes MLPAB-1472

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/app/donor_store.go 91.17% <100.00%> (ø)
internal/page/data.go 93.05% <100.00%> (+0.15%) ⬆️
internal/page/donor/payment_confirmation.go 91.83% <100.00%> (ø)
internal/page/donor/register.go 100.00% <100.00%> (ø)
internal/page/donor/upload_evidence.go 88.37% <100.00%> (ø)
internal/s3/client.go 89.47% <100.00%> (+3.75%) ⬆️
cmd/event-received/main.go 49.73% <59.37%> (-2.79%) ⬇️

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@acsauk acsauk changed the title MLPAB-1472: Handle document-scanned events MLPAB-1472: Update virus scanning results on evidence in dynamodb Oct 18, 2023
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 18, 2023 18:32 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 19, 2023 08:49 — with GitHub Actions Inactive
@acsauk acsauk marked this pull request as ready for review October 19, 2023 09:00
@acsauk acsauk requested a review from a team as a code owner October 19, 2023 09:00
hawx
hawx reviewed Oct 19, 2023
View reviewed changes
cmd/event-received/main.go Outdated Show resolved Hide resolved
internal/page/data.go Outdated Show resolved Hide resolved
internal/page/data.go Outdated Show resolved Hide resolved
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 19, 2023 09:26 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 19, 2023 10:04 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 20, 2023 10:29 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 20, 2023 11:41 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 20, 2023 12:43 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 23, 2023 14:35 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 23, 2023 15:54 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 23, 2023 16:43 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_779mlpab147 October 23, 2023 21:06 — with GitHub Actions Inactive
@acsauk acsauk merged commit 168df52 into main Oct 24, 2023
@acsauk acsauk deleted the MLPAB-1472 branch October 24, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawx hawx hawx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acsauk @hawx