Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLPAB-1406 MLPAB-1407 MLPAB-1412 MLPAB-1409 Previous application changes #808

Merged
merged 2 commits into from
Oct 31, 2023
Merged

MLPAB-1406 MLPAB-1407 MLPAB-1412 MLPAB-1409 Previous application changes #808

merged 2 commits into from
Oct 31, 2023

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Oct 30, 2023

No description provided.

@hawx hawx self-assigned this Oct 30, 2023
@hawx hawx requested a review from a team as a code owner October 30, 2023 13:39
@hawx hawx force-pushed the MLPAB-1406-delete-application-reason-page branch 2 times, most recently from 73cc358 to 48801ed Compare October 30, 2023 14:13
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/app/donor_store.go 92.30% <ø> (-0.05%) ⬇️
internal/page/data.go 93.05% <ø> (ø)
internal/page/donor/lpa_type.go 100.00% <100.00%> (ø)
internal/page/donor/previous_application_number.go 100.00% <100.00%> (ø)
internal/page/donor/register.go 100.00% <ø> (ø)
.../page/donor/which_fee_type_are_you_applying_for.go 100.00% <100.00%> (ø)
internal/page/paths.go 100.00% <ø> (ø)
internal/validation/check.go 100.00% <100.00%> (ø)
internal/validation/error.go 7.57% <0.00%> (-0.49%) ⬇️

📢 Thoughts on this report? Let us know!.

@hawx hawx force-pushed the MLPAB-1406-delete-application-reason-page branch from 48801ed to c3f302c Compare October 30, 2023 14:59
@hawx hawx force-pushed the MLPAB-1406-delete-application-reason-page branch from c3f302c to 7b3c7d4 Compare October 30, 2023 15:24
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

PR Environment Terraform Plan Summary

Plan: 2 to add, 5 to change, 1 to destroy

@hawx hawx temporarily deployed to dev_808mlpab140 October 30, 2023 15:53 — with GitHub Actions Inactive
@hawx hawx force-pushed the MLPAB-1406-delete-application-reason-page branch from 7b3c7d4 to 6352b04 Compare October 31, 2023 08:53
acsauk
acsauk approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hawx hawx merged commit 1350f05 into main Oct 31, 2023
23 checks passed
@hawx hawx deleted the MLPAB-1406-delete-application-reason-page branch October 31, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acsauk acsauk acsauk approved these changes

@andrewpearce-digital andrewpearce-digital andrewpearce-digital approved these changes

Assignees

@hawx hawx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawx @andrewpearce-digital @acsauk